Skip to content

feat(e2ee): renew certificate#17344

Merged
alperozturk96 merged 4 commits into
masterfrom
feat/e2ee-renew-certificate
Jul 24, 2026
Merged

feat(e2ee): renew certificate#17344
alperozturk96 merged 4 commits into
masterfrom
feat/e2ee-renew-certificate

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Matches with: nextcloud/ios#4189

Screenshot_20260717_084607
Screenshot_20260717_084625

@alperozturk96
alperozturk96 requested a review from kra-mo July 17, 2026 07:06
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29561981588/artifacts/8399759382
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 marked this pull request as draft July 17, 2026 07:29
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29566751450/artifacts/8401654187
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96
alperozturk96 marked this pull request as ready for review July 17, 2026 09:29
@tobiasKaminsky

tobiasKaminsky commented Jul 22, 2026

Copy link
Copy Markdown
Member

Please retest with iOS : like this

  • create new e2e setup on Android
  • add ios
  • renew on Android
  • test on current Android
  • check if ios still works
  • add a second Android device
  • add a second iOS

@alperozturk96
alperozturk96 force-pushed the feat/e2ee-renew-certificate branch from 27530b3 to 749bc79 Compare July 24, 2026 07:33
@alperozturk96
feat(e2ee): renew certificate
b9e4c34 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
fix is matching
7a9c063 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
clear confusion between certificate and public key
c4dd4bd 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
add tests
40212c3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the feat/e2ee-renew-certificate branch from 749bc79 to 40212c3 Compare July 24, 2026 08:21
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/30078642663/artifacts/8591005872
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code208208
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total394394

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@alperozturk96

alperozturk96 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator Author

Tested working.

@alperozturk96
alperozturk96 merged commit 983d6b5 into master Jul 24, 2026
19 of 22 checks passed
@alperozturk96
alperozturk96 deleted the feat/e2ee-renew-certificate branch July 24, 2026 08:40
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17344-IT-master-10-58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes
@marinofaggiana marinofaggiana Awaiting requested review from marinofaggiana
@kra-mo kra-mo Awaiting requested review from kra-mo

Assignees

No one assigned

Labels

3. to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky